DOCSP-43953: v2 iterator changes #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
approved these changes
Oct 22, 2024
| @@ -8,8 +8,8 @@ Definition | |||
| .. phpclass:: MongoDB\Model\CollectionInfo | |||
|
|
|||
| This class models information about a collection. Instances of this class are | |||
| returned by traversing a :phpclass:`MongoDB\Model\CollectionInfoIterator`, | |||
| which is returned by :phpmethod:`MongoDB\Database::listCollections()`. | |||
| returned in an `Iterator <{+php-manual}/class.iterator.php>`__ | |||
There was a problem hiding this comment.
S: [nit] since this sentence uses "returned" twice, you could change to "stored"
Suggested change
| returned in an `Iterator <{+php-manual}/class.iterator.php>`__ | |
| stored in an `Iterator <{+php-manual}/class.iterator.php>`__ |
| @@ -8,8 +8,8 @@ Definition | |||
| .. phpclass:: MongoDB\Model\CollectionInfo | |||
|
|
|||
| This class models information about a collection. Instances of this class are | |||
| returned by traversing a :phpclass:`MongoDB\Model\CollectionInfoIterator`, | |||
| which is returned by :phpmethod:`MongoDB\Database::listCollections()`. | |||
| returned in an `Iterator <{+php-manual}/class.iterator.php>`__ | |||
There was a problem hiding this comment.
I: add the closing + to fix the link:
Suggested change
| returned in an `Iterator <{+php-manual}/class.iterator.php>`__ | |
| returned in an `Iterator <{+php-manual+}/class.iterator.php>`__ |
There was a problem hiding this comment.
Applies to all Iterator links
rustagir
force-pushed
the
DOCSP-43953-v2-iterator-changes
branch
from
9cd5448 to
73bd978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43953
Staging - https://deploy-preview-172--docs-php-library.netlify.app/whats-new/#std-label-php-lib-version-2.0
Self-Review Checklist